You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm using and enjoying this with Ghostty as well. Just one curiosity I noticed: The cursor renders a bit funny when it's placed on a tab character, which spans multiple cells. The upper cursor is the secondary one, the lower cursor is the primary one. The hardware cursor seems to render a single cell with a different color than the rest of the cells belonging to the tab character.
The problem seems to be that the "hardware" cursor doesn't get the theme's color for the cursor. This problem is most pronounced on light themes. A white cursor on white background is invisible. Should be a blocking issue IMO.
The problem seems to be that the "hardware" cursor doesn't get the theme's color for the cursor. This problem is most pronounced on light themes. A white cursor on white background is invisible. Should be a blocking issue IMO.
You’ll see this issue already with bar/underline cursors. Terminal cursors use the terminal’s foreground colour, Helix can’t theme them.
I believe this PR forces an unthemable cursor on all users, it will always draw the terminal cursor overlaid on Helix’s block cursor? That’s why #16163 introduces block-hardware, making it opt-in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables smear cursor shader on word movements. Tested with ghostty.
Fixes #14512
Edit: #16163 looks like a more forward-looking change in a similar vein.